✨ Z_HOMING_WITH_PROBE_AFTER_Z_ENDSTOP#28037
✨ Z_HOMING_WITH_PROBE_AFTER_Z_ENDSTOP#2803712oclocker wants to merge 60 commits intoMarlinFirmware:bugfix-2.1.xfrom
Conversation
Added feature + bugfix USE_PROBE_FOR_Z_HOMING_AFTER_Z_ENDSTOP which solves reported bugs 27680, 22653, 21727, 21833, 27821
/** * For machines with Z endstops and BLTOUCH sensors working together. * Enable this option to home with BLTOUCH probe after Z endstop homing. * This allows "Z Probe Offset" changes to take effect immediately without * having to rebuild bed leveling mesh. Usefull for Z_MULTI_ENDSTOPS * machines where enstops are needed to sync the Z motors. * (Automatically enables USE_PROBE_FOR_Z_HOMING.) */ #define USE_PROBE_FOR_Z_HOMING_AFTER_Z_ENDSTOP
USE_PROBE_FOR_Z_HOMING_AFTER_Z_ENDSTOP added
Added missing pin defines in AnyCubic i3 Mega, file pins_TRIGORILLA_14.h
BugFix for BLTOUCH with Z_ENDSTOPS
BugFix for BLTOUCH with Z_ENDSTOPS
Added missing pin defines in pins_TRIGORILLA_14.h
BugFix for BLTOUCH with Z EndStops
Z_HOMING_WITH_PROBE_AFTER_Z_ENDSTOP added
Added Z_HOMING_WITH_PROBE_AFTER_Z_ENDSTOP condition check
added Z_HOMING_WITH_PROBE_AFTER_Z_ENDSTOP
added Z_HOMING_WITH_PROBE_AFTER_Z_ENDSTOP
added Z_HOMING_WITH_PROBE_AFTER_Z_ENDSTOP
added Z_HOMING_WITH_PROBE_AFTER_Z_ENDSTOP
BugFix for BLTOUCH with Z EndStops
BugFix for BLTOUCH with Z EndStops
BugFix for BLTOUCH with Z EndStops
BugFix for BLTOUCH with Z EndStops
added Z_HOMING_WITH_PROBE_AFTER_Z_ENDSTOP
BugFix for BLTOUCH with Z EndStops
BugFix for BLTOUCH with Z EndStops
BugFix for BLTOUCH with Z EndStops
BugFix for Z Probe + Z EndStops
bf59633 to
a3c9d00
Compare
|
Made some modifications to the description. There is no reason that Z homing cannot be done with the nozzle, and the utility of this feature is tied to a machine with a Z axis that must home to MAX, for one reason or another. This may be best for machines with a Z bed that homes to the bottom. TODO: It makes sense to require |
6b25cf4 to
266705b
Compare
fixed conflict with base Marlin-bugfix-2.1.x
REHOME_Z_WITH_PROBE optimizations
REHOME_Z_WITH_PROBE optimizations
REHOME_Z_WITH_PROBE optimizations
REHOME_Z_WITH_PROBE optimizations
REHOME_Z_WITH_PROBE optimizations
REHOME_Z_WITH_PROBE optimizations
REHOME_Z_WITH_PROBE optimizations
REHOME_Z_WITH_PROBE optimizations
REHOME_Z_WITH_PROBE optimizations
|
@thinkyhead I agree with your changes and comments. I started an attempt for the flag to be just a function parameter, and unfortunately that opens a can of worms into other functions which seems to bloat the code worse than the global flag.... the global flag seems to follow suit with variables such as relative_mode and z_min_trusted which already existed... Maybe combining relative_mode and z_min_trusted and z_homing_use_probe into a single uint8_t later down the road and using bits for flags would be better, that would probably have to be evaluated though. I have required Z_SAFE_HOMING as you have recommended, though the home_z_safely function is slightly different than needed during re-homing. home_z_safely does not move Z first to prevent dragging nozzle across the build plate. Also home_z_safely is not in a scope that can be called directly from motion.cpp, luckily all we need is just a Z move to probe deploy position, then XY to Z_SAFE_HOMING position, which is simple enough. A case could be made that instead of a recursive homeaxis call, we simply call it twice from G28.cpp, then home_z_safely is in scope, but also home_z_safely would need modified so that Z moves first, which may alter other functions that depend on home_z_safely to remain as it is. As the code is now everything works fine and home_z_safely is unmodified. I also noticed TERN0 TERN1 and TERN only work for defines that are defined to 1 or undefined. Thus I had to fix a section of my code which use_probe_bump was not actually grabbing the value of Z_CLEARANCE_BETWEEN_PROBES when it should have. That issue is now also resolved. I have tested the newly modified version of this code, running on my AnyCubic i3 Mega machines, and it is working well. |
REHOME_Z_WITH_PROBE optimizations
REHOME_Z_WITH_PROBE optimizations
52532da to
06c6c47
Compare
1bc0732 to
72c7874
Compare
Description
Requirements
Requirement for the new code to take effect,
define Z_HOMING_WITH_PROBE_AFTER_Z_ENDSTOP
enable any Z endstop sensors as well as a probe
Benefits
Configurations
Attach Configurations ZIP and any other files needed to test this PR.
Test Configs are for AnyCubicI3 mega with BLTOUCH and MKS_MINI_12864_V3 display
configs.zip
Make sure to add "Z_HOMING_WITH_PROBE_AFTER_Z_ENDSTOP"
to the Configuration.h file
Related Issues